flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2272: [FLINK-4231] [java] Switch DistinctOperator from G...
Date Thu, 18 Aug 2016 15:43:34 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2272#discussion_r75333518
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java
---
    @@ -202,7 +203,9 @@ public void setCustomPartitioner(Partitioner<?> customPartitioner)
{
     
     		if (inputColumns.length > 0) {
     			boolean[] inputOrderings = new boolean[inputColumns.length];
    -			TypeComparator<T> inputComparator = ((CompositeType<T>) inputType).createComparator(inputColumns,
inputOrderings, 0, executionConfig);
    +			TypeComparator<T> inputComparator = inputType instanceof BasicTypeInfo
    +					? ((BasicTypeInfo<T>) inputType).createComparator(inputOrderings[0], executionConfig)
    --- End diff --
    
    Cast to `AtomicType`. `inputOrderings[0]` can be replaced by `false`, since the array
fields are not explicitly initialized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message