flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...
Date Thu, 18 Aug 2016 13:28:21 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75307091
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java
---
    @@ -100,13 +101,51 @@ public void testSubmissionTimeout() throws Exception {
     		Await.result(jobExecutionResult, timeout);
     	}
     
    +
    +	/** Tests that a {@link JobClientActorRegistrationTimeoutException} is thrown when the
registration
    +	 * cannot be performd at the JobManager by the JobClientActor. This is here the case,
because the
    +	 * started JobManager never replies to a {@link RegisterJobClient} message.
    +	 */
    +	@Test(expected=JobClientActorRegistrationTimeoutException.class)
    +	public void testRegistrationTimeout() throws Exception {
    +		FiniteDuration jobClientActorTimeout = new FiniteDuration(5, TimeUnit.SECONDS);
    +		FiniteDuration timeout = jobClientActorTimeout.$times(2);
    +
    +		UUID leaderSessionID = UUID.randomUUID();
    +
    +		ActorRef jobManager = system.actorOf(
    +			Props.create(
    +				PlainActor.class,
    +				leaderSessionID));
    +
    +		TestingLeaderRetrievalService testingLeaderRetrievalService = new TestingLeaderRetrievalService(
    +			jobManager.path().toString(),
    +			leaderSessionID
    +		);
    +
    +		Props jobClientActorProps = JobClientActor.createJobClientActorProps(
    +			testingLeaderRetrievalService,
    +			jobClientActorTimeout,
    +			false);
    +
    +		ActorRef jobClientActor = system.actorOf(jobClientActorProps);
    +
    +
    --- End diff --
    
    Two line breaks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message