flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #2355: [FLINK-4282]Add Offset Parameter to WindowAssigner...
Date Thu, 18 Aug 2016 13:24:13 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2355#discussion_r75306425
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowingTestHarnessTest.java
---
    @@ -84,6 +86,84 @@ public void testEventTimeTumblingWindows() throws Exception {
     	}
     
     	@Test
    +	public void testEventTimeTumblingWindowsWithOffset() throws Exception {
    --- End diff --
    
    These tests should go into `WindowOperatorTest`. The existing tests here are just meant
to exercise the `WindowTestHarness`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message