flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...
Date Thu, 18 Aug 2016 13:16:52 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75305261
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClientActor.java
---
    @@ -198,10 +211,47 @@ else if (message instanceof SubmitJobAndWait) {
     					decorateMessage(new Status.Failure(new Exception(msg))), ActorRef.noSender());
     			}
     		}
    +		else if (message instanceof AttachToJobAndWait) {
    --- End diff --
    
    At the moment the `JobClientActor` can be used to attach to a job and submit a new job
at the same time. Then depending on the order in which the jobs terminate either the submitted
job's or the attached job's result is reported back but the other future will never be completed.
It might make sense to guard against this or to have two different JobClientActors based on
the same base class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message