flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wenlong88 <...@git.apache.org>
Subject [GitHub] flink pull request #2381: [FLINK-4414][cluster management] Remove restrictio...
Date Wed, 17 Aug 2016 16:29:06 GMT
Github user wenlong88 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2381#discussion_r75157339
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
---
    @@ -197,11 +201,11 @@ public void stopService() {
     	}
     
     	@Override
    -	public String getAddress(RpcGateway selfGateway) {
    +	public String getAddress(RpcGateway gateway) {
     		checkState(!stopped, "RpcService is stopped");
     
    -		if (selfGateway instanceof AkkaGateway) {
    -			ActorRef actorRef = ((AkkaGateway) selfGateway).getRpcEndpoint();
    +		if (gateway instanceof AkkaGateway) {
    +			ActorRef actorRef = ((AkkaGateway) gateway).getActorRef();
     			return AkkaUtils.getAkkaURL(actorSystem, actorRef);
    --- End diff --
    
    yeah, you are right. It is a problem I have missed checking. Added the connected actor
to the caches in case of mixed actor system to make current solution work


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message