flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #2300: [FLINK-4245] [metrics] Expose all defined variables
Date Wed, 17 Aug 2016 12:39:57 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2300
  
    Looks mostly good. I noticed a few things:
    
    I am not quite sure about the lazy initialization. The idea is good, but the current double-check-locking
pattern is not multi-thread safe (http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html).
Either we make each access a little more expensive (declare the field `volatile`), or we eagerly
initialize the maps.
    
    As a followup, we should probably look into adjusting the JMX reporter. Is there a way
we can expose all tags?
    
    Can you also rebase this to the latest master? It has a bunch of merge conflicts right
now, when trying to test it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message