flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2288: Feature/s3 a fix
Date Wed, 17 Aug 2016 09:03:01 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2288#discussion_r75086582
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
    @@ -62,4 +64,34 @@ public void run() {
     			throw asyncException.f0;
     		}
     	}
    +
    +	/**
    +	 * Ensure that target path terminates with a new directory to be created by fs. If remoteURI
does not specify a new
    +	 * directory, append local directory name.
    +	 * @param fs
    +	 * @param localPath
    +	 * @param remoteURI
    +	 * @return
    +	 * @throws IOException
    +	 */
    +	protected static URI checkInitialDirectory(final FileSystem fs,final File localPath,
final URI remoteURI) throws IOException {
    +		if (localPath.isDirectory()) {
    +			Path remotePath = new Path(remoteURI);
    +			if (fs.exists(remotePath)) {
    +				return new Path(remotePath,localPath.getName()).toUri();
    +			}
    +		}
    +		return remoteURI;
    +	}
    +
    +	protected static void copyFromLocalFile(final FileSystem fs, final File localPath, final
URI remotePath) throws Exception {
    --- End diff --
    
    Yes makes sense. :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message