flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2371: [FLINK-4309] Potential null pointer dereference in...
Date Tue, 16 Aug 2016 08:25:42 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2371#discussion_r74894098
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/DelegatingConfiguration.java
---
    @@ -178,14 +178,19 @@ public String toString() {
     
     	@Override
     	public Set<String> keySet() {
    +
     		final HashSet<String> set = new HashSet<String>();
    -		final int prefixLen = this.prefix == null ? 0 : this.prefix.length();
     
     		for (String key : this.backingConfig.keySet()) {
    -			if (key.startsWith(this.prefix)) {
    +
    +			if (this.prefix == null) {
    --- End diff --
    
    Actually, it's probably better to just return the keySet of the backing config.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message