flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2141: [FLINK-4021] Problem of setting autoread for netty...
Date Mon, 15 Aug 2016 13:22:59 GMT
Github user uce commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandler.java
    @@ -292,7 +296,11 @@ else if (bufferListener.waitForBuffer(bufferProvider, bufferOrEvent))
     						return false;
     					else if (bufferProvider.isDestroyed()) {
    -						return false;
    --- End diff --
    We usually have a white space between keywords like `if` or `else`:
    if (isStagedBuffer) {
        return true;
    } else {
        return false;
    In this case, you can simplify the return value to `return isStagedBuffer`. Same for the
other place where you use this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message