flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #2244: [FLINK-3874] Add a Kafka TableSink with JSON seria...
Date Sun, 14 Aug 2016 11:00:33 GMT
Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2244#discussion_r74699857
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
    @@ -590,7 +592,7 @@ class Table(
           .map(field => FlinkTypeFactory.toTypeInfo(field.getType)).toArray
     
         // configure the table sink
    -    val configuredSink = sink.configure(fieldNames, fieldTypes)
    +    val configuredSink = sink.asInstanceOf[TableSinkBase[T]].configure(fieldNames, fieldTypes)
    --- End diff --
    
    It seems that KafkaTableSink doesn't extends TableSinkBase, so that does it work if the
input sink is a KafkaTableSink ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message