flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...
Date Thu, 11 Aug 2016 09:58:08 GMT
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/2244
  
    @mushketyk Thanks for your PR. I added some comments to the code. The changes you made
to the `TableSink` class structure seem reasonable. However, it might be better if those change
would be made in a separate Jira issue and PR.
    
    In general, it would be great if you try to touch as little existing code as possible
and orientate yourself more on the existing code base.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message