Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2746A200B56 for ; Fri, 15 Jul 2016 09:25:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2613B160A61; Fri, 15 Jul 2016 07:25:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 775C3160A6C for ; Fri, 15 Jul 2016 09:25:21 +0200 (CEST) Received: (qmail 13265 invoked by uid 500); 15 Jul 2016 07:25:20 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 13242 invoked by uid 99); 15 Jul 2016 07:25:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 07:25:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8BAE02C0034 for ; Fri, 15 Jul 2016 07:25:20 +0000 (UTC) Date: Fri, 15 Jul 2016 07:25:20 +0000 (UTC) From: "Tzu-Li (Gordon) Tai (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (FLINK-4194) KinesisDeserializationSchema.isEndOfStream() is never called MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 15 Jul 2016 07:25:22 -0000 [ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378902#comment-15378902 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4194 at 7/15/16 7:25 AM: --------------------------------------------------------------------- I wonder if it would actually make more sense to name the method {{isEndOfShard()}}, and only stop a single {{ShardConsumer}} to stop consuming a shard when its {{true}}. So, in a sense this is opting to go with the behaviour of the {{FlinkKafkaConsumer08}} (stop only a partition), but renaming the method to match this behaviour. I think by renaming to {{isEndOfShard()}} the intention of the method will be much more defined, and probably more useful for the user too? Like you said, currently {{isEndOfStream()}} behaviour can't really be defined, and I find it quite confusing myself, when the stream is continuing to fetch data (from other shard/partitions) even when the condition of {{isEndOfStream()}} is met. What do you think? was (Author: tzulitai): I wonder if it would actually make more sense to name the method {{isEndOfShard()}}, and only stop a single {{ShardConsumer}} to stop consuming a shard when its {{true}}. So, in a sense this is opting to go with the behaviour of the {{FlinkKafkaConsumer08}}, but renaming the method to match this behaviour. I think by renaming to {{isEndOfShard()}} the intention of the method will be much more defined, and probably more useful for the user too? Like you said, currently {{isEndOfStream()}} behaviour can't really be defined, and I find it quite confusing myself, when the stream is continuing to fetch data (from other shard/partitions) even when the condition of {{isEndOfStream()}} is met. What do you think? > KinesisDeserializationSchema.isEndOfStream() is never called > ------------------------------------------------------------ > > Key: FLINK-4194 > URL: https://issues.apache.org/jira/browse/FLINK-4194 > Project: Flink > Issue Type: Sub-task > Components: Kinesis Connector > Affects Versions: 1.1.0 > Reporter: Robert Metzger > Assignee: Tzu-Li (Gordon) Tai > > The Kinesis connector does not respect the {{KinesisDeserializationSchema.isEndOfStream()}} method. > The purpose of this method is to stop consuming from a source, based on input data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)