Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mxm <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2275-flink@git.apache.org>
In-Reply-To: <git-pr-2275-flink@git.apache.org>
Subject: [GitHub] flink pull request #2275: FLINK-3929 Support for Kerberos Authentication wit...
Content-Type: text/plain
Message-Id: <20160727142304.4C949E02A2@git1-us-west.apache.org>
Date: Wed, 27 Jul 2016 14:23:04 +0000 (UTC)
archived-at: Wed, 27 Jul 2016 14:23:08 -0000

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2275#discussion_r72448259
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java ---
    @@ -81,13 +90,21 @@ public static void prepare() throws IOException, ClassNotFoundException {
     		LOG.info("-------------------------------------------------------------------------");
     		LOG.info("    Starting KafkaTestBase ");
     		LOG.info("-------------------------------------------------------------------------");
    -		
     
    +		Configuration flinkConfig = new Configuration();
     
     		// dynamically load the implementation for the test
     		Class<?> clazz = Class.forName("org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl");
     		kafkaServer = (KafkaTestEnvironment) InstantiationUtil.instantiate(clazz);
     
    +		LOG.info("Runtype: {}", RunTypeHolder.get());
    +		if(RunTypeHolder.get().equals(RunTypeHolder.RunType.SECURE)
    --- End diff --
    
    You can use `==` for enum comparisons.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---