Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C8AF200B4F for ; Tue, 26 Jul 2016 11:47:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4B36F160A75; Tue, 26 Jul 2016 09:47:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 923D8160A56 for ; Tue, 26 Jul 2016 11:47:05 +0200 (CEST) Received: (qmail 5205 invoked by uid 500); 26 Jul 2016 09:47:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 5196 invoked by uid 99); 26 Jul 2016 09:47:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 09:47:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6693CC034D for ; Tue, 26 Jul 2016 09:47:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id wZCDatV-eGIK for ; Tue, 26 Jul 2016 09:47:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5D15C5FB4A for ; Tue, 26 Jul 2016 09:47:01 +0000 (UTC) Received: (qmail 5174 invoked by uid 99); 26 Jul 2016 09:47:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 09:47:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 77886E08E8; Tue, 26 Jul 2016 09:47:00 +0000 (UTC) From: uce To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #2286: [FLINK-4210][metrics] Move close()/isClosed() out of Metr... Content-Type: text/plain Message-Id: <20160726094700.77886E08E8@git1-us-west.apache.org> Date: Tue, 26 Jul 2016 09:47:00 +0000 (UTC) archived-at: Tue, 26 Jul 2016 09:47:06 -0000 Github user uce commented on the issue: https://github.com/apache/flink/pull/2286 Looks good to merge. Following the discussion in the JIRA, I think it's nice to move it out. I had one minor inline comment and the commit message has a typo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---