Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2266-flink@git.apache.org>
In-Reply-To: <git-pr-2266-flink@git.apache.org>
Subject: [GitHub] flink pull request #2266: [FLINK-4229] Do not start any Metrics Reporter by ...
Content-Type: text/plain
Message-Id: <20160720125037.05EF2E04BA@git1-us-west.apache.org>
Date: Wed, 20 Jul 2016 12:50:37 +0000 (UTC)
archived-at: Wed, 20 Jul 2016 12:50:43 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2266#discussion_r71517800
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java ---
    @@ -50,9 +50,10 @@
     	public void testJobManagerMetricAccess() throws Exception {
     		Deadline deadline = new FiniteDuration(2, TimeUnit.MINUTES).fromNow();
     		Configuration flinkConfiguration = new Configuration();
    -		
    +
    +		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_CLASS, "org.apache.flink.metrics.reporter.JMXReporter");
     		flinkConfiguration.setString(ConfigConstants.METRICS_SCOPE_NAMING_JM_JOB, "jobmanager.<job_name>");
    -		flinkConfiguration.setString(ConfigConstants.METRICS_JMX_PORT, "9060-9075");
    +		flinkConfiguration.setString(ConfigConstants.METRICS_REPORTER_ARGUMENTS, "-port 9060-9075");
    --- End diff --
    
    arguments are prefixed with a double dash `--`. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---