Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 60E87200B45 for ; Fri, 15 Jul 2016 13:13:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5FB10160A6C; Fri, 15 Jul 2016 11:13:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A7BE4160A61 for ; Fri, 15 Jul 2016 13:13:30 +0200 (CEST) Received: (qmail 15376 invoked by uid 500); 15 Jul 2016 11:13:29 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 15367 invoked by uid 99); 15 Jul 2016 11:13:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 11:13:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 45C06188176 for ; Fri, 15 Jul 2016 11:13:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fQin6m2n_5CT for ; Fri, 15 Jul 2016 11:13:28 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A674E5F341 for ; Fri, 15 Jul 2016 11:13:27 +0000 (UTC) Received: (qmail 15338 invoked by uid 99); 15 Jul 2016 11:13:26 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 11:13:26 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B9A03E0A3F; Fri, 15 Jul 2016 11:13:26 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #2252: [FLINK-3466] [runtime] Cancel state handled on sta... Content-Type: text/plain Message-Id: <20160715111326.B9A03E0A3F@git1-us-west.apache.org> Date: Fri, 15 Jul 2016 11:13:26 +0000 (UTC) archived-at: Fri, 15 Jul 2016 11:13:31 -0000 Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2252#discussion_r70956861 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/AbstractFileStateHandle.java --- @@ -20,18 +20,21 @@ import org.apache.flink.core.fs.FileSystem; import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.state.AbstractCloseableHandle; +import org.apache.flink.runtime.state.StateObject; import java.io.IOException; +import java.io.Serializable; import static java.util.Objects.requireNonNull; /** * Base class for state that is stored in a file. */ -public abstract class AbstractFileStateHandle implements java.io.Serializable { - +public abstract class AbstractFileStateHandle extends AbstractCloseableHandle implements StateObject, Serializable { --- End diff -- True, will remove this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---