flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4184) Ganglia and GraphiteReporter report metric names with invalid characters
Date Wed, 13 Jul 2016 14:58:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375162#comment-15375162

ASF GitHub Bot commented on FLINK-4184:

Github user tillrohrmann commented on the issue:

    I rebased on the latest master and introduced a `CharacterFilter` interface. The `CharacterFilter`
allows to filter out invalid characters while generating the fully qualified metric name.

    In order to do this, the `AbstractMetricGroup#generateMetricName` takes a `CharacterFilter`
as argument. The `AbstractReporter` and the `ScheduledDropwizardReporter` implement this interface
to filter out reporter specific characters.

> Ganglia and GraphiteReporter report metric names with invalid characters
> ------------------------------------------------------------------------
>                 Key: FLINK-4184
>                 URL: https://issues.apache.org/jira/browse/FLINK-4184
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.1.0
> Flink's {{GangliaReporter}} and {{GraphiteReporter}} report metrics with names which
contain invalid characters. For example, quotes are not filtered out which can be problematic
for Ganglia. Moreover, dots are not replaced which causes Graphite to think that an IP address
is actually a scoped metric name.

This message was sent by Atlassian JIRA

View raw message