flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4159) Quickstart poms exclude unused dependencies
Date Fri, 08 Jul 2016 14:48:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367767#comment-15367767
] 

ASF GitHub Bot commented on FLINK-4159:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2217#discussion_r70085553
  
    --- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
---
    @@ -207,15 +206,9 @@ under the License.
     									<exclude>com.esotericsoftware.kryo:kryo</exclude>
     									<exclude>com.esotericsoftware.minlog:minlog</exclude>
     									<exclude>org.objenesis:objenesis</exclude>
    -									<exclude>com.twitter:chill_*</exclude>
    --- End diff --
    
    I also see that this was not in the list in the Jira for FLINK-4159.


> Quickstart poms exclude unused dependencies
> -------------------------------------------
>
>                 Key: FLINK-4159
>                 URL: https://issues.apache.org/jira/browse/FLINK-4159
>             Project: Flink
>          Issue Type: Bug
>          Components: Quickstarts
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> The Quickstart poms exclude several dependencies from being packaged into the fat-jar,
even though they aren't used by Flink according to `mvn dependency:tree`.
> <exclude>com.amazonaws:aws-java-sdk</exclude>
> <exclude>com.twitter:chill-avro_*</exclude>
> <exclude>com.twitter:chill-bijection_*</exclude>
> <exclude>com.twitter:bijection-core_*</exclude>
> <exclude>com.twitter:bijection-avro_*</exclude>
> <exclude>de.javakaffee:kryo-serializers</exclude>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message