flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3891) Add a class containing all supported Table API types
Date Mon, 25 Jul 2016 12:12:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391789#comment-15391789
] 

ASF GitHub Bot commented on FLINK-3891:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2292#discussion_r72052751
  
    --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/CastingITCase.java
---
    @@ -138,50 +138,5 @@ public void testCastFromString() throws Exception {
     		String expected = "1,1,1,1,2.0,2.0,true\n";
     		compareResultAsText(results, expected);
     	}
    -
    -	@Ignore // Date type not supported yet
    -	@Test
    -	public void testCastDateFromString() throws Exception {
    --- End diff --
    
    Yes, they have been moved to `TimeTypesTest`. This is just a forgotten test that is not
necessary anymore.


> Add a class containing all supported Table API types
> ----------------------------------------------------
>
>                 Key: FLINK-3891
>                 URL: https://issues.apache.org/jira/browse/FLINK-3891
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Minor
>
> In order to make working with the Table API easier. It would be great to have a class
that contains the supported types.
> Such that an expression could look like:
> {code}
> .select(42.cast(TableType.INT), 43.cast(TableType.DECIMAL))
> {code}
> The constants would map to the original TypeInformation object (in BasicTypeInfo, SqlTimeTypeInfo,
etc.).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message