flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] flink pull request #2301: FLINK-3674 Add an interface for EventTime aware Us...
Date Wed, 27 Jul 2016 10:35:10 GMT
Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2301#discussion_r72417108
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperator.java
---
    @@ -55,13 +56,18 @@
     	
     	/** the user function */
     	protected final F userFunction;
    +
    +	protected EventTimeFunction eventTimeFunction;
     	
     	/** Flag to prevent duplicate function.close() calls in close() and dispose() */
     	private transient boolean functionsClosed = false;
     	
     	
     	public AbstractUdfStreamOperator(F userFunction) {
     		this.userFunction = requireNonNull(userFunction);
    +		if(userFunction instanceof  EventTimeFunction) {
    --- End diff --
    
    Thanks for the super quick review. A quick question - In intellij IDE how should a formatting
 be applied?  In Eclipse Ctrl+Shift+F applies the formatter that was configured. How about
here?  I can update the next commit based on that. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message