flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2301: FLINK-3674 Add an interface for EventTime aware Us...
Date Wed, 27 Jul 2016 10:33:41 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2301#discussion_r72416957
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
    @@ -2003,6 +2048,53 @@ public void apply(String key,
     
     	}
     
    +	public static class RichSumReducerWithEventTime<W extends Window> extends RichWindowFunction<Tuple2<String,
Integer>, Tuple2<String, Integer>, String, W>
    +		implements EventTimeFunction<String, W> {
    +		private static final long serialVersionUID = 1L;
    +
    +		private boolean openCalled = false;
    +		private static int count = 0;
    +		@Override
    +		public void open(Configuration parameters) throws Exception {
    +			super.open(parameters);
    +			openCalled = true;
    +		}
    +
    +		@Override
    +		public void close() throws Exception {
    +			super.close();
    +			closeCalled.incrementAndGet();
    +		}
    +
    +		@Override
    +		public void apply(String key,
    +						  W window,
    +						  Iterable<Tuple2<String, Integer>> input,
    --- End diff --
    
    this _should_ fail checkstyle, as the indentation is partly done with spaces. we only
use tabs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message