flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #2123: [FLINK-3904] GlobalConfiguration doesn't ensure co...
Date Mon, 25 Jul 2016 14:21:07 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2123#discussion_r72071650
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
---
    @@ -84,12 +84,11 @@
     	 */
     	private static int MAX_SAMPLE_LEN;
     
    -	static { loadGlobalConfigParams(); }
    -	
    -	protected static void loadGlobalConfigParams() {
    -		int maxSamples = GlobalConfiguration.getInteger(ConfigConstants.DELIMITED_FORMAT_MAX_LINE_SAMPLES_KEY,
    +
    +	protected static void loadConfigParameters(Configuration parameters) {
    --- End diff --
    
    I think this is a public API change. The class is annotated with `@Public` and the method
is `protected`, which means that some users might have extended this input format and rely
on this method. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message