flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkamkou <...@git.apache.org>
Subject [GitHub] flink pull request #2281: RMQ Sink: Possibility to customize queue config [F...
Date Fri, 22 Jul 2016 13:20:06 GMT
Github user kkamkou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2281#discussion_r71876785
  
    --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
    @@ -58,6 +58,15 @@ public RMQSink(RMQConnectionConfig rmqConnectionConfig, String queueName,
Serial
     	}
     
     	/**
    +	 * Sets up the queue. The default implementation just declares the queue. The user may
override
    +	 * this method to have a custom setup for the queue (i.e. binding the queue to an exchange
or
    +	 * defining custom queue parameters)
    +	 */
    +	protected void setupQueue() throws IOException {
    +		channel.queueDeclare(queueName, false, false, false, null);
    --- End diff --
    
    channel should be protected


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message