flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...
Date Mon, 18 Jul 2016 09:51:33 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2257#discussion_r71122579
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -405,36 +374,13 @@ class JobManager(
     
           currentResourceManager match {
             case Some(rm) =>
    -          val future = (rm ? decorateMessage(new RegisterResource(taskManager, msg)))(timeout)
    -          future.onComplete {
    -            case scala.util.Success(response) =>
    -              // the resource manager is available and answered
    -              self ! response
    -            case scala.util.Failure(t) =>
    -              t match {
    -                case _: TimeoutException =>
    -                  log.info("Attempt to register resource at ResourceManager timed out.
Retrying")
    -                case _ =>
    -                  log.warn("Failure while asking ResourceManager for RegisterResource.
Retrying", t)
    -              }
    -              // slow or unreachable resource manager, register anyway and let the rm
reconnect
    -              self ! decorateMessage(new RegisterResourceSuccessful(taskManager, msg))
    -              self ! decorateMessage(new ReconnectResourceManager(rm))
    -          }(context.dispatcher)
    -
    +          log.info(s"Register task manager $resourceId at the resource manager.")
    +          rm ! decorateMessage(new RegisterResource(msg))
    --- End diff --
    
    What if this message gets lost? This message needs to be delivered, otherwise the RM won't
function properly. The RM may not run on the same node as the JobManager, making message loss
even more likely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message