flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2249: 4166 zookeeper namespaces
Date Thu, 14 Jul 2016 20:22:31 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2249#discussion_r70876628
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
    @@ -285,6 +291,18 @@ public static ZooKeeperCheckpointIDCounter createCheckpointIDCounter(
     		}
     	}
     
    +	private static String generateZookeeperPath(String root, String namespace) {
    +		if(!namespace.startsWith("/")) {
    --- End diff --
    
    missing space after if, and a second time a few lines downwards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message