flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2220: [FLINK-4184] [metrics] Replace invalid characters ...
Date Thu, 14 Jul 2016 09:41:58 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2220#discussion_r70777251
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/groups/AbstractMetricGroup.java
---
    @@ -100,10 +101,29 @@ public AbstractMetricGroup(MetricRegistry registry, String[] scope)
{
     	 * @return fully qualified metric name
          */
     	public String getMetricIdentifier(String metricName) {
    +		return getMetricIdentifier(metricName, null);
    +	}
    +
    +	/**
    +	 * Returns the fully qualified metric name, for example
    +	 * {@code "host-7.taskmanager-2.window_word_count.my-mapper.metricName"}
    +	 *
    +	 * @param metricName metric name
    +	 * @param filter character filter which is applied to the fully qualified metric name
    --- End diff --
    
    Will adapt the comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message