flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2236: [FLINK-4186] Use Flink metrics to report Kafka met...
Date Wed, 13 Jul 2016 09:23:28 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2236#discussion_r70591698
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
---
    @@ -161,6 +163,11 @@ public Histogram getHistogram(String name) {
     	}
     
     	@Override
    +	public MetricGroup getMetricGroup() {
    +		return new UnregisteredTaskMetricsGroup.DummyIOMetricGroup();
    --- End diff --
    
    You don't really have to override this method, using the TaskMetricGroup is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message