flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter
Date Wed, 13 Jul 2016 07:43:12 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2219#discussion_r70577752
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
    @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {
     		}
     		this.scopeFormats = scopeFormats;
     
    +		char delim;
    +		try {
    +			delim = config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0);
    --- End diff --
    
    Sorry, it was a hick-up of Github, because it didn't show me that I posted the comment
so I thought I clicked on cancel.
    
    Why not changing `ScopeFormat.concat` such that it always takes a delimiter string as
first parameter? Giving `""` as first argument will lead to the former variant where you don't
specify a delimiter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message