flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2225: [FLINK-4191] Expose shard information in kinesis d...
Date Mon, 11 Jul 2016 20:08:49 GMT
Github user rmetzger commented on a diff in the pull request:

    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
    @@ -206,7 +206,13 @@ private void deserializeRecordForCollectionAndUpdateState(UserRecord
     		final long approxArrivalTimestamp = record.getApproximateArrivalTimestamp().getTime();
     		final T value = deserializer.deserialize(
    -			keyBytes, dataBytes, subscribedShard.getStreamName(), record.getSequenceNumber(),
    +				keyBytes,
    +				dataBytes,
    +				record.getPartitionKey(),
    +				record.getSequenceNumber(),
    +				approxArrivalTimestamp,
    +				subscribedShard.getStreamName(),
    +				subscribedShard.getShard().getShardId());
    --- End diff --
    Fixed the indention.
    I don't think that having a separate final variable for this will improve the performance
a lot. The methods are computing anything.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message