flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #1954: [FLINK-3190] failure rate restart strategy
Date Fri, 08 Jul 2016 15:51:11 GMT
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/1954
  
    The changes look good to me. Thanks for your work @fijolekProjects :-) I had one final
remark concerning the `FixedSizeFifoQueue`. Maybe we could try to replace it with the `ArrayDeque`.

    
    I think you cannot make `ArrayDeque` fixed in size, but this is not a problem if you check
the size before appending elements. If the maximum size is reached, then we have to remove
elements from the queue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message