flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator
Date Fri, 08 Jul 2016 13:18:29 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2169#discussion_r70071730
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
    @@ -236,6 +236,32 @@ case class Aggregate(
       }
     }
     
    +case class SetMinus(left: LogicalNode, right: LogicalNode, all: Boolean) extends BinaryNode
{
    --- End diff --
    
    I would still call it `Minus` to be in sync with `Union`, `Intersect`, etc. but that's
just my personal opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message