flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2212: [FLINK-4171] [metrics] Replace : chars in StatsD m...
Date Thu, 07 Jul 2016 13:41:38 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2212#discussion_r69907730
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java
---
    @@ -74,4 +74,14 @@ public void notifyOfRemovedMetric(Metric metric, String metricName,
AbstractMetr
     			}
     		}
     	}
    +
    +	/**
    +	 * Can be overridden by sub-classes to replace invalid characters in metric name.
    +	 *
    +	 * @param metricName Name of the metric
    --- End diff --
    
    Name should be lower case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message