flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector
Date Mon, 04 Jul 2016 09:06:04 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r69428684
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisClusterConfig.java
---
    @@ -0,0 +1,186 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.redis.common.config;
    +
    +import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
    +import org.apache.flink.util.Preconditions;
    +import redis.clients.jedis.HostAndPort;
    +import redis.clients.jedis.Protocol;
    +
    +import java.net.InetSocketAddress;
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +/**
    + * Configuration for Jedis Cluster.
    + */
    +public class FlinkJedisClusterConfig extends FlinkJedisConfigBase {
    +	private static final long serialVersionUID = 1L;
    +
    +	private Set<InetSocketAddress> nodes;
    +	private int maxRedirections;
    +
    +
    +	/**
    +	 * Jedis cluster configuration.
    +	 * The list of node is mandatory, and when nodes is not set, it throws NullPointerException.
    +	 *
    +	 * @param nodes list of node information for JedisCluster
    +	 * @param connectionTimeout socket / connection timeout. The default is 2000
    +	 * @param maxRedirections limit of redirections-how much we'll follow MOVED or ASK
    +	 * @param maxTotal the maximum number of objects that can be allocated by the pool
    +	 * @param maxIdle the cap on the number of "idle" instances in the pool
    +	 * @param minIdle the minimum number of idle objects to maintain in the pool
    +	 * @throws NullPointerException if parameter {@code nodes} is {@code null}
    +	 */
    +	private FlinkJedisClusterConfig(Set<InetSocketAddress> nodes, int connectionTimeout,
int maxRedirections,
    +									int maxTotal, int maxIdle, int minIdle) {
    +		super(connectionTimeout, maxTotal, maxIdle, minIdle);
    +
    +		Preconditions.checkNotNull(nodes, "Node information should be presented");
    --- End diff --
    
    Should we throw on `nodes.isEmpty()` ?
    Maybe also make a copy of the `Set` to ensure it cannot be altered from outside?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message