flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...
Date Mon, 04 Jul 2016 04:57:59 GMT
Github user wuchong commented on the issue:

    https://github.com/apache/flink/pull/2078
  
    Hi @gallenvara , I debug the  `IndexOutOfBoundsException` exception of  `testJoinWithDisjunctivePred`,
and find this line [L526 in CodeGenerator](https://github.com/apache/flink/blob/master/flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala#L526).
 This is the reason for the test failure.   Because  `==` in scala is `equals`,when we visit
inputRef of 'd, the input1 and input2 have the same field types ([Int, Long, String]). Here
we will get the wrong index(3) which cause IOOB exception, but we want to get the index(0).

    
    We just need to modify L526 to `val index = if (input._2 == input1Term) {` will fix this
problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message