Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1172200B26 for ; Mon, 27 Jun 2016 12:11:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CF9BA160A3C; Mon, 27 Jun 2016 10:11:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4BC79160A5B for ; Mon, 27 Jun 2016 12:11:54 +0200 (CEST) Received: (qmail 72677 invoked by uid 500); 27 Jun 2016 10:11:52 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 72649 invoked by uid 99); 27 Jun 2016 10:11:52 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jun 2016 10:11:52 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 032E12C14DC for ; Mon, 27 Jun 2016 10:11:52 +0000 (UTC) Date: Mon, 27 Jun 2016 10:11:52 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4121) Add timeunit (ms) to docs for timestamps and watermarks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 27 Jun 2016 10:11:55 -0000 [ https://issues.apache.org/jira/browse/FLINK-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350743#comment-15350743 ] ASF GitHub Bot commented on FLINK-4121: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2165 > Add timeunit (ms) to docs for timestamps and watermarks > ------------------------------------------------------- > > Key: FLINK-4121 > URL: https://issues.apache.org/jira/browse/FLINK-4121 > Project: Flink > Issue Type: Improvement > Components: DataStream API > Reporter: Jonas Traub > Priority: Trivial > > I'm teaching a class where students are supposed to implement Flink streaming programs. It seems to be unclear for them, that the time unit of timestamps and watermarks is milliseconds. > They just see TimeWindow.seconds(...) or something similar and assume the timestamps to be of the same unit (seconds) which is obviously not the case. > I just checked the documentation and there is no explicit specification of the time unit used for timestamps. > After short talk with [~aljoscha], I'll open a mini-PR to address this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)