Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 30 Jun 2016 15:07:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12983003.1466835538000.4763.1467299230110@Atlassian.JIRA>
In-Reply-To: <JIRA.12983003.1466835538000@Atlassian.JIRA>
References: <JIRA.12983003.1466835538000@Atlassian.JIRA> <JIRA.12983003.1466835538626@arcas>
Subject: [jira] [Commented] (FLINK-4118) The docker-flink image is outdated
 (1.0.2) and can be slimmed down
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 30 Jun 2016 15:07:11 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4118?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1535=
7224#comment-15357224 ]=20

ASF GitHub Bot commented on FLINK-4118:
---------------------------------------

Github user iemejia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2176#discussion_r69150030
 =20
    --- Diff: flink-contrib/docker-flink/README.md ---
    @@ -1,80 +1,75 @@
    -#Apache Flink cluster deployment on Docker using Docker-Compose
    +Apache Flink cluster deployment on docker using docker-compose
    =20
    -##Installation
    -###Install Docker
    +# Installation
    =20
    +Install the most recent stable version of docker
     https://docs.docker.com/installation/
    =20
    -if you have issues with Docker-Compose versions incompatible with your=
 version of Docker try
    +Install the most recent stable version of docker-compose
    +https://docs.docker.com/compose/install/
    =20
    -`curl -sSL https://get.docker.com/ubuntu/ | sudo sh`
    +# Build
    =20
    -###Install Docker-Compose
    +Images are based on the official Java Alpine (OpenJDK 8) image and run
    +supervisord to stay alive when running containers. If you want to buil=
d the
    +flink image run:
    =20
    -```
    -curl -L https://github.com/docker/compose/releases/download/1.1.0/dock=
er-compose-`uname -s`-`uname -m` > /usr/local/bin/docker-compose
    +    sh build.sh
    =20
    -chmod +x /usr/local/bin/docker-compose
    -```
    -
    -###Get the repo
    -
    -###Build the images
    +or
    =20
    -Images are based on Ubuntu Trusty 14.04 and run Supervisord to stay al=
ive when running containers.
    +    docker build -t "flink" flink
    --- End diff --
   =20
    Nice catch, just fixed :)


> The docker-flink image is outdated (1.0.2) and can be slimmed down
> ------------------------------------------------------------------
>
>                 Key: FLINK-4118
>                 URL: https://issues.apache.org/jira/browse/FLINK-4118
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Isma=C3=ABl Mej=C3=ADa
>            Priority: Minor
>
> This issue is to upgrade the docker image and polish some details in it (=
e.g. it can be slimmed down if we remove some unneeded dependencies, and th=
e code can be polished).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)