Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7AF3B200B17 for ; Tue, 21 Jun 2016 12:16:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 797F7160A4F; Tue, 21 Jun 2016 10:16:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E716A160A36 for ; Tue, 21 Jun 2016 12:16:58 +0200 (CEST) Received: (qmail 1800 invoked by uid 500); 21 Jun 2016 10:16:58 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 1786 invoked by uid 99); 21 Jun 2016 10:16:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2016 10:16:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 009302C1F5D for ; Tue, 21 Jun 2016 10:16:58 +0000 (UTC) Date: Tue, 21 Jun 2016 10:16:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4082) Add Setting for LargeRecordHandler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Jun 2016 10:16:59 -0000 [ https://issues.apache.org/jira/browse/FLINK-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15341508#comment-15341508 ] ASF GitHub Bot commented on FLINK-4082: --------------------------------------- Github user uce commented on the issue: https://github.com/apache/flink/pull/2113 Changes look good, but did you skip the `CombiningUnilateralSortMerger` on purpose? It's hard to tell, because the `handleLargeRecords` argument was existing before your changes, but it was not configurable. The `CombiningUnilateralSortMerger` always sets `handleLargeRecords` to `true`. > Add Setting for LargeRecordHandler > ---------------------------------- > > Key: FLINK-4082 > URL: https://issues.apache.org/jira/browse/FLINK-4082 > Project: Flink > Issue Type: Improvement > Reporter: Aljoscha Krettek > Assignee: Aljoscha Krettek > > Now, this is always enabled but there are known problems when users specify a custom {{TypeInformation}}. We should introduce a setting for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)