Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 30 Jun 2016 16:44:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12950794.1458120461000.5698.1467305050361@Atlassian.JIRA>
In-Reply-To: <JIRA.12950794.1458120461000@Atlassian.JIRA>
References: <JIRA.12950794.1458120461000@Atlassian.JIRA> <JIRA.12950794.1458120461626@arcas>
Subject: [jira] [Commented] (FLINK-3618) Rename abstract UDF classes in
 Scatter-Gather implementation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 30 Jun 2016 16:44:12 -0000


    [ https://issues.apache.org/jira/browse/FLINK-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357436#comment-15357436 ] 

ASF GitHub Bot commented on FLINK-3618:
---------------------------------------

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2184
  
    Thanks for the update @greghogan! +1 to merge.


> Rename abstract UDF classes in Scatter-Gather implementation
> ------------------------------------------------------------
>
>                 Key: FLINK-3618
>                 URL: https://issues.apache.org/jira/browse/FLINK-3618
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.1.0, 1.0.1
>            Reporter: Martin Junghanns
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> We now offer three Vertex-centric computing abstractions:
> * Pregel
> * Gather-Sum-Apply
> * Scatter-Gather
> Each of these abstractions provides abstract classes that need to be implemented by the user:
> * Pregel: {{ComputeFunction}}
> * GSA: {{GatherFunction}}, {{SumFunction}}, {{ApplyFunction}}
> * Scatter-Gather: {{MessagingFunction}}, {{VertexUpdateFunction}}
> In Pregel and GSA, the names of those functions follow the name of the abstraction or the name suggested in the corresponding papers. For consistency of the API, I propose to rename {{MessageFunction}} to {{ScatterFunction}} and {{VertexUpdateFunction}} to {{GatherFunction}}.
> Also for consistency, I would like to change the parameter order in {{Graph.runScatterGatherIteration(VertexUpdateFunction f1, MessagingFunction f2}} to  {{Graph.runScatterGatherIteration(ScatterFunction f1, GatherFunction f2}} (like in {{Graph.runGatherSumApplyFunction(...)}})


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)