Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: wuchong <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2182-flink@git.apache.org>
In-Reply-To: <git-pr-2182-flink@git.apache.org>
Subject: [GitHub] flink pull request #2182: [Flink-4130] CallGenerator could generate illegal ...
Content-Type: text/plain
Message-Id: <20160629153213.06647E5CE1@git1-us-west.apache.org>
Date: Wed, 29 Jun 2016 15:32:13 +0000 (UTC)
archived-at: Wed, 29 Jun 2016 15:32:19 -0000

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2182#discussion_r68969768
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/CallGenerator.scala ---
    @@ -43,11 +43,16 @@ object CallGenerator {
         val nullTerm = newName("isNull")
         val resultTypeTerm = primitiveTypeTermForTypeInfo(returnType)
         val defaultValue = primitiveDefaultValue(returnType)
    +    val nullCheckTerms = if(operands.size > 0) {
    +      operands.map(_.nullTerm).mkString(" || ")
    +    } else {
    +      nullCheck + ""
    +    }
    --- End diff --
    
    It seems that when operands.size == 0  and nullCheck is enable, the `$nullTerm` will always be true, which means `$resultTerm` always be the default value.  That may be wrong. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---