Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: zentol <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2145-flink@git.apache.org>
In-Reply-To: <git-pr-2145-flink@git.apache.org>
Subject: [GitHub] flink pull request #2145: [FLINK-4087] [metrics] Improved JMX port handling
Content-Type: text/plain
Message-Id: <20160623101508.DA810E38B1@git1-us-west.apache.org>
Date: Thu, 23 Jun 2016 10:15:08 +0000 (UTC)
archived-at: Thu, 23 Jun 2016 10:15:14 -0000

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2145#discussion_r68209393
  
    --- Diff: flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
    @@ -73,10 +86,61 @@ public JMXReporter() {
     	// ------------------------------------------------------------------------
     
     	@Override
    -	public void open(Configuration config) {}
    +	public void open(Configuration config) {
    +		this.jmxServer = startJmxServer(config);
    +	}
    +
    +	private static JMXServer startJmxServer(Configuration config) {
    +		JMXServer jmxServer;
    +
    +		String portRange = config.getString(KEY_METRICS_JMX_PORT, "9010-9025");
    +		String[] ports = portRange.split("-");
    +
    +		if (ports.length == 0 || ports.length > 2) {
    +			throw new IllegalArgumentException("JMX port range was configured incorrectly. " +
    +				"Expected: <startPort>[-<endPort>] Configured: " + portRange);
    +		}
    +
    +		if (ports.length == 1) { //single port was configured
    +			int port = Integer.parseInt(ports[0]);
    +			jmxServer = new JMXServer(port);
    +			try {
    +				jmxServer.start();
    +			} catch (IOException e) {
    +				throw new RuntimeException("Could not start JMX server on port " + port + ".");
    +			}
    +			return jmxServer;
    +		} else { //port range was configured
    +			int start = Integer.parseInt(ports[0]);
    +			int end = Integer.parseInt(ports[1]);
    +			while (true) {
    +				try {
    +					jmxServer = new JMXServer(start);
    +					jmxServer.start();
    +					LOG.info("Starting JMX on port " + start + ".");
    --- End diff --
    
    I can add it as a debug statement, but can that information not be inferred from the configured ports and the final port used? (all configured ports < final port)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---