Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: aljoscha <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2124-flink@git.apache.org>
In-Reply-To: <git-pr-2124-flink@git.apache.org>
Subject: [GitHub] flink issue #2124: [FLINK-3647] Change StreamSource to use Processing-Time C...
Content-Type: text/plain
Message-Id: <20160621160727.A7CC7E020A@git1-us-west.apache.org>
Date: Tue, 21 Jun 2016 16:07:27 +0000 (UTC)
archived-at: Tue, 21 Jun 2016 16:07:32 -0000

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2124
  
    This looks very good! I just have a few minor comments:
    
    * It's very good that you fixed typos and added comments/Javadoc to previously undocumented code. I would like to see them as a separate PR, though, and keep this PR only to the feature mentioned in the Jiras. 
    
    * You added `TestTimeServiceProvider` in two tests. I think it makes sense to move this to the same package as `DefaultTimerService` and clearly mark it as being for testing only. On a related note, it might make sense to normalize the names, right now there is `*TimeServiceProvider` and `*TimerService`.
    
    * You added the additional method `registerTimer(final long timestamp, final Runnable target)`. I imagine it is because the sources register their watermark timers as a `Runnable`. I think it would be better to keep having only `Triggerable` here. The watermark emitters should also work as a `Triggerable`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---