Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mjsax <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1813-flink@git.apache.org>
In-Reply-To: <git-pr-1813-flink@git.apache.org>
Subject: [GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector
Content-Type: text/plain
Message-Id: <20160619185418.5A6E2E02A1@git1-us-west.apache.org>
Date: Sun, 19 Jun 2016 18:54:18 +0000 (UTC)
archived-at: Sun, 19 Jun 2016 18:54:25 -0000

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r67621988
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisPoolConfig.java ---
    @@ -0,0 +1,275 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis.common.config;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
    +import redis.clients.jedis.Protocol;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Configuration for Jedis Pool.
    + */
    +public class JedisPoolConfig implements Serializable {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private String host;
    +	private int port;
    +	private int timeout;
    +	private int database;
    +	private String password;
    +	private int maxTotal;
    +	private int maxIdle;
    +	private int minIdle;
    +
    +	/**
    +	 * The host is mandatory, and when host is not set, it throws NullPointerException.
    +	 *
    +	 * @param host host hostname or IP
    +	 * @param port port port
    +	 * @param timeout timeout socket / connection timeout
    +	 * @param password password password, if any
    +	 * @param database database database index
    +	 * @param maxTotal maxTotal the maximum number of objects that can be allocated by the pool
    +	 * @param maxIdle the cap on the number of "idle" instances in the pool
    +     * @param minIdle the minimum number of idle objects to maintain in the pool
    +	 * @throws NullPointerException if do not see host
    --- End diff --
    
    @throws NullPointerException if parameter {@code host} is {@code null}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---