Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EDC6D2009F8 for ; Fri, 3 Jun 2016 21:34:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EC75F160A50; Fri, 3 Jun 2016 19:34:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EF1E160A3B for ; Fri, 3 Jun 2016 21:34:03 +0200 (CEST) Received: (qmail 31785 invoked by uid 500); 3 Jun 2016 19:34:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 31776 invoked by uid 99); 3 Jun 2016 19:34:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 19:34:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 09D6118059B for ; Fri, 3 Jun 2016 19:34:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DSeaKo_xinJ5 for ; Fri, 3 Jun 2016 19:34:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 0161B5F36D for ; Fri, 3 Jun 2016 19:34:00 +0000 (UTC) Received: (qmail 31743 invoked by uid 99); 3 Jun 2016 19:34:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jun 2016 19:34:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 130FBDFC92; Fri, 3 Jun 2016 19:34:00 +0000 (UTC) From: rmetzger To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #2069: [FLINK-3872] [table, connector-kafka] Add KafkaJsonTableS... Content-Type: text/plain Message-Id: <20160603193400.130FBDFC92@git1-us-west.apache.org> Date: Fri, 3 Jun 2016 19:34:00 +0000 (UTC) archived-at: Fri, 03 Jun 2016 19:34:04 -0000 Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2069 Quickly checked the maven and kafka stuff. Looks good. Very clean, well documented and tested code. Further review for the table api specific parts are still needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---