flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script
Date Tue, 28 Jun 2016 12:04:57 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352871#comment-15352871
] 

ASF GitHub Bot commented on FLINK-4084:
---------------------------------------

Github user alkagin commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2149#discussion_r68743480
  
    --- Diff: flink-dist/src/main/flink-bin/bin/flink ---
    @@ -17,20 +17,41 @@
     # limitations under the License.
     ################################################################################
     
    -target="$0"
     # For the case, the executable has been directly symlinked, figure out
     # the correct bin path by following its symlink up to an upper bound.
     # Note: we can't use the readlink utility here if we want to be POSIX
     # compatible.
    -iteration=0
    -while [ -L "$target" ]; do
    -    if [ "$iteration" -gt 100 ]; then
    -        echo "Cannot resolve path: You have a cyclic symlink in $target."
    +followSymLink() {
    +    local iteration=0
    +    local bar=$1
    +    while [ -L "$bar" ]; do
    +        if [ "$iteration" -gt 100 ]; then
    +            echo "Cannot resolve path: You have a cyclic symlink in $bar."
    +            break
    +        fi
    +        ls=`ls -ld -- "$bar"`
    +        bar=`expr "$ls" : '.* -> \(.*\)$'`
    +        iteration=$((iteration + 1))
    +    done
    +
    +    echo "$bar"
    +}
    +
    +target=$(followSymLink "$0")
    +
    +#Search --configDir into the parameters and set it as FLINK_CONF_DIR
    +args=("$@")
    +for i in "${!args[@]}"; do
    +    if [ ${args[$i]} = "--configDir" ]; then
    --- End diff --
    
    There is already one, we need two? 


> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
>                 Key: FLINK-4084
>                 URL: https://issues.apache.org/jira/browse/FLINK-4084
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>
> At the moment there is no other way than the environment variable FLINK_CONF_DIR to specify
the configuration directory for the CliFrontend if it is started via the flink shell script.
In order to improve the user exprience, I would propose to introduce a {{--configDir}} parameter
which the user can use to specify a configuration directory more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message