flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4064) Allow calling MetricGroup methods multiple times
Date Mon, 13 Jun 2016 13:27:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327359#comment-15327359

Chesnay Schepler commented on FLINK-4064:

This would effectively mean a mandatory additional hash-lookup if a metric is supposed to
be gathered within onElement.This seems quite wasteful.

can't users store the metric in a field within the trigger and check for null in every call?
it's more boiler-plate code but should be more efficient.

> Allow calling MetricGroup methods multiple times
> ------------------------------------------------
>                 Key: FLINK-4064
>                 URL: https://issues.apache.org/jira/browse/FLINK-4064
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Aljoscha Krettek
> Right now, the methods on {{MetricGroup}} can only be called once, i.e. I have to keep
the result of {{MetricGroup.counter(name)}} and use that to report metrics. For some cases,
such as adding metrics support in triggers, it is necessary to allow calling a method multiple
times and return the same metric object. On the first call, a new metric object would be created,
subsequent calls would return that metric object.

This message was sent by Atlassian JIRA

View raw message