flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null
Date Fri, 24 Jun 2016 14:32:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348349#comment-15348349
] 

ASF GitHub Bot commented on FLINK-4053:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2128#discussion_r68406562
  
    --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/Utils.java
---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.rabbitmq.common;
    +
    +import com.rabbitmq.client.Channel;
    +import com.rabbitmq.client.Connection;
    +
    +import java.io.IOException;
    +
    +/**
    + * Common utils for RabbitMQ streaming connector.
    + */
    +public class Utils {
    +	private Utils() {}
    +
    +	/**
    +	 *	Create RabbitMQ and check for null reference.
    +	 *
    +	 * @param connection RabbitMQ connection
    +	 * @return RabbitMQ channel
    +	 * @throws IOException if failed to open RabbitMQ channel
    +	 * @throws RuntimeException if connection object returned null channel
    +	 */
    +	public static Channel createChannel(Connection connection) throws IOException {
    --- End diff --
    
    a separate class and static method is a bit overkill for a null check.


> Return value from Connection should be checked against null
> -----------------------------------------------------------
>
>                 Key: FLINK-4053
>                 URL: https://issues.apache.org/jira/browse/FLINK-4053
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>
> In RMQSource.java and RMQSink.java, there is code in the following pattern:
> {code}
>       connection = factory.newConnection();
>       channel = connection.createChannel();
> {code}
> According to https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel()
:
> {code}
> Returns:
> a new channel descriptor, or null if none is available
> {code}
> The return value should be checked against null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message