flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3977) Subclasses of InternalWindowFunction must support OutputTypeConfigurable
Date Thu, 16 Jun 2016 16:13:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334087#comment-15334087
] 

ASF GitHub Bot commented on FLINK-3977:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/2118

    [FLINK-3977] InternalWindowFunctions implement OutputTypeConfigurable and forward calls
to wrapped functions.

    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink windowOutTConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2118
    
----
commit 973ee7fd797bb5e92c5e664075e2e33d21eed28f
Author: Fabian Hueske <fhueske@apache.org>
Date:   2016-06-16T07:09:40Z

    [FLINK-3977] InternalWindowFunctions implement OutputTypeConfigurable and forward calls
to wrapped functions.

----


> Subclasses of InternalWindowFunction must support OutputTypeConfigurable
> ------------------------------------------------------------------------
>
>                 Key: FLINK-3977
>                 URL: https://issues.apache.org/jira/browse/FLINK-3977
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Fabian Hueske
>            Priority: Critical
>
> Right now, if they wrap functions and a wrapped function implements {{OutputTypeConfigurable}},
{{setOutputType}} is never called. This manifests itself, for example, in FoldFunction on
a window with evictor not working.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message