flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3937) Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters
Date Mon, 13 Jun 2016 14:52:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327532#comment-15327532
] 

ASF GitHub Bot commented on FLINK-3937:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2085#discussion_r66805479
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
    @@ -211,18 +185,45 @@ public void run() {
     		Runtime.getRuntime().addShutdownHook(clientShutdownHook);
     
     		isConnected = true;
    +
    +		logAndSysout("Waiting until all TaskManagers have connected");
    +
    +		while(true) {
    --- End diff --
    
    Yes, I wanted to bring up the Yarn session only once the cluster is ready. It is a semantic
change but IMHO transparent to the user. There is not disadvantage from waiting until the
cluster is ready. Ultimately, it would be nice to get rid of all waiting but we're not quite
there yet.


> Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-3937
>                 URL: https://issues.apache.org/jira/browse/FLINK-3937
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Sebastian Klemke
>            Assignee: Maximilian Michels
>            Priority: Trivial
>         Attachments: improve_flink_cli_yarn_integration.patch
>
>
> Currently, flink cli can't figure out JobManager RPC location for Flink-on-YARN clusters.
Therefore, list, savepoint, cancel and stop subcommands are hard to invoke if you only know
the YARN application ID. As an improvement, I suggest adding a -yid <yarnApplicationId>
option to the mentioned subcommands that can be used together with -m yarn-cluster. Flink
cli would then retrieve JobManager RPC location from YARN ResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message