flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3650) Add maxBy/minBy to Scala DataSet API
Date Tue, 14 Jun 2016 20:33:30 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330533#comment-15330533
] 

ASF GitHub Bot commented on FLINK-3650:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1856#discussion_r67050838
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java ---
    @@ -557,7 +557,7 @@ public long count() throws Exception {
     		}
     
     		return new ReduceOperator<>(this, new SelectByMaxFunction(
    -				(TupleTypeInfo) getType(), fields), Utils.getCallLocationName());
    --- End diff --
    
    Please revert this change.


> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
>                 Key: FLINK-3650
>                 URL: https://issues.apache.org/jira/browse/FLINK-3650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. These methods
are not supported by the Scala DataSet API. These methods should be added in order to have
a consistent API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message