flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3650) Add maxBy/minBy to Scala DataSet API
Date Wed, 15 Jun 2016 12:46:09 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331658#comment-15331658
] 

ASF GitHub Bot commented on FLINK-3650:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1856#discussion_r67154017
  
    --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/SelectByMinFunction.scala
---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.scala
    +
    +import org.apache.flink.annotation.Internal
    +import org.apache.flink.api.common.functions.ReduceFunction
    +import org.apache.flink.api.java.typeutils.TupleTypeInfoBase
    +
    +/**
    +  * SelectByMinFunction to work with Scala tuples
    +  */
    +@Internal
    +class SelectByMinFunction[T](t : TupleTypeInfoBase[T], val fields : Array[Int])
    +  extends ReduceFunction[T] {
    +  for(f1 <- fields) {
    +    if (f1 < 0 || f1 >= t.getArity()) {
    +      throw new IndexOutOfBoundsException(
    +        "MinReduceFunction field position " + f1 + " is out of range.")
    +    }
    +    // Check whether type is comparable
    +
    +    if (!t.asInstanceOf[TupleTypeInfoBase[T]].getTypeAt(f1).isKeyType()) {
    +      throw new IllegalArgumentException(
    +        "MinReduceFunction supports only key(Comparable) types.")
    --- End diff --
    
    `MinReduceFunction` -> `SelectByMinFunction`


> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
>                 Key: FLINK-3650
>                 URL: https://issues.apache.org/jira/browse/FLINK-3650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. These methods
are not supported by the Scala DataSet API. These methods should be added in order to have
a consistent API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message